Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the openImmediatly flag in favor of the autoOpen option #830

Merged
merged 1 commit into from
May 29, 2016

Conversation

reconbot
Copy link
Member

closes #809

autoOpen makes a lot more sense to me. What do you think?

callback = null;
function SerialPort(path, options, callback) {
if (typeof callback === 'boolean') {
throw new TypeError('`openImmediately` is now called `autoOpen` and is a property of options');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see people not reading the upgrade notes for a while and this should help prevent issues with that.

@reconbot reconbot merged commit 77c4ea3 into master May 29, 2016
@reconbot reconbot deleted the openImmediately branch May 29, 2016 01:33
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

Move the openImmediately flag to the port options.
1 participant